This is consistent with what is used to create the disk image supplied by virt-builder. It doesn't currently affect the outcome of the test, but it's possible that in the future it could. In particular, the network device name changes depending on whether or not there is a graphics device (due to change in PCI address). The virt-builder image is create by installing Fedora on a guest that has no graphics card, so it sees the network device as "ens2" and creates an appropriate ifcfg-ens2, but if you boot the image with a graphics card, then the network device will be named "ens3". It turns out that NetworkManager is enabled by default on the virt-builder images, and NetworkManager will listen for dhcp on *all* interfaces (not just those with a configuration file), so networking still functions on the guest, but if a test script were to try to use "ifdown ens3" (for example) that wouldn't work. The best solution may be to have the image set "biosdevnames=0 net.ifnames=0" on the kernel commandline (so that the netdev is always called "eth0" regardless of its PCI address), but that would also need to be done in the kickstart file used to create the image, which is done offline by libguestfs people, so it's not something we have control over here. --- lib/Sys/Virt/TCK.pm | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/lib/Sys/Virt/TCK.pm b/lib/Sys/Virt/TCK.pm index b39f578..ce8e81b 100644 --- a/lib/Sys/Virt/TCK.pm +++ b/lib/Sys/Virt/TCK.pm @@ -781,11 +781,6 @@ sub generic_machine_domain { $b->boot_disk(); - $b->graphics(type => "vnc", - port => "-1", - autoport => "yes", - listen => "127.0.0.1"); - $b->disk(src => $config{root}, dst => $config{dev}, type => "file"); @@ -795,6 +790,7 @@ sub generic_machine_domain { $b->interface(type => "network", source => "default", + model => "virtio", mac => "52:54:00:11:11:11", filterref => "clean-traffic"); my $xml = $b->as_xml(); @@ -840,11 +836,6 @@ sub generic_machine_domain { # XXX boot CDROM or vroot for other HVs $b->boot_kernel($config{kernel}, $config{initrd}); - $b->graphics(type => "vnc", - port => "-1", - autoport => "yes", - listen => "127.0.0.1"); - $b->disk(src => $config{root}, dst => $config{dev}, type => "file"); @@ -930,6 +921,7 @@ sub generic_domain { if ($netmode eq "vepa") { $b->interface(type => "direct", source => "default", + model => "virtio", mac => "52:54:00:11:11:11", dev => $self->get_host_network_device(), mode => "vepa", @@ -937,6 +929,7 @@ sub generic_domain { } else { $b->interface(type => "network", source => "default", + model => "virtio", mac => "52:54:00:11:11:11", filterref => "clean-traffic"); } -- 2.13.6

On Wed, Feb 07, 2018 at 09:04:52PM -0500, Laine Stump wrote: Upto this point Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com&gt; Just split that into a second patch if still needed Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

Net::SSH::Perl is out of date in the Fedora git repos. The version currently supported in Fedora fails to connect to most modern sshd's, and updating to the new version would require adding several new perl packages to Fedora. Instead, this patch switches to using Net::OpenSSH, whose current version in Fedora works properly *EXCEPT* that it is missing the line "Requires: perl(IO:TTy)" in its specfiles (I filed https://bugzilla.redhat.com/1542666 requesting that fix to be applied to Fedora git repos. For now, just run "dnf install perl-IO-Tty" separately) NB: prior to this patch, Net::SSH::Perl was required, but had no Required: line in the specfile, so you would have to install it by hand. If you had done that, you can probably now dnf erase it. --- perl-Sys-Virt-TCK.spec.PL | 3 ++- scripts/nwfilter/100-ping-still-working.t | 1 - scripts/nwfilter/210-no-mac-spoofing.t | 27 ++++++++++++++------------- scripts/nwfilter/220-no-ip-spoofing.t | 23 ++++++++++++----------- scripts/nwfilter/230-no-mac-broadcast.t | 23 ++++++++++++----------- scripts/nwfilter/240-no-arp-spoofing.t | 23 ++++++++++++----------- scripts/nwfilter/300-vsitype.t | 1 - 7 files changed, 52 insertions(+), 49 deletions(-) diff --git a/perl-Sys-Virt-TCK.spec.PL b/perl-Sys-Virt-TCK.spec.PL index 9a10880..4172499 100644 --- a/perl-Sys-Virt-TCK.spec.PL +++ b/perl-Sys-Virt-TCK.spec.PL @@ -37,7 +37,7 @@ __DATA__ Summary: Sys::Virt::TCK - libvirt Technology Compatibility Kit Name: perl-%{appname} Version: @VERSION@ -Release: 1%{_extra_release} +Release: 99%{_extra_release} License: GPLv2 Group: Development/Tools Source: http://libvirt.org/sources/tck/%{appname}-v%{version}.tar.gz @@ -73,6 +73,7 @@ Requires: perl(Test::Exception) Requires: perl(TAP::Formatter::HTML) Requires: perl(TAP::Formatter::JUnit) Requires: perl(TAP::Harness::Archive) +Requires: perl(Net::OpenSSH) Requires: /usr/bin/mkisofs BuildArchitectures: noarch diff --git a/scripts/nwfilter/100-ping-still-working.t b/scripts/nwfilter/100-ping-still-working.t index dc1efd2..5afc6a6 100644 --- a/scripts/nwfilter/100-ping-still-working.t +++ b/scripts/nwfilter/100-ping-still-working.t @@ -32,7 +32,6 @@ use Test::More tests => 4; use Sys::Virt::TCK; use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; -use Net::SSH::Perl; use File::Spec::Functions qw(catfile catdir rootdir); diff --git a/scripts/nwfilter/210-no-mac-spoofing.t b/scripts/nwfilter/210-no-mac-spoofing.t index 03001a8..eb01d13 100644 --- a/scripts/nwfilter/210-no-mac-spoofing.t +++ b/scripts/nwfilter/210-no-mac-spoofing.t @@ -31,7 +31,7 @@ use Test::More tests => 5; use Sys::Virt::TCK; use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; -use Net::SSH::Perl; +use Net::OpenSSH; use File::Spec::Functions qw(catfile catdir rootdir); @@ -88,9 +88,10 @@ diag $ping; ok($ping =~ "10 received", "ping $guestip test"); # log into guest -my $ssh = Net::SSH::Perl->new($guestip); diag "ssh'ing into $guestip"; -$ssh->login("root", $tck->root_password()); +my $ssh = Net::OpenSSH->new($guestip, + user => "root", + password => $tck->root_password()); # now bring eth0 down, change MAC and bring it up again diag "fiddling with mac"; @@ -108,26 +109,26 @@ echo "DEV=`ip link | head -3 | tail -1 | awk '{print \\\$2}' | sed -e 's/://'` /sbin/ip addr show dev \\\$DEV" > /test.sh EOF diag $cmdfile; -my ($stdout, $stderr, $exit) = $ssh->cmd($cmdfile); +my ($stdout, $stderr) = $ssh->capture2($cmdfile); diag $stdout; diag $stderr; -diag $exit; -($stdout, $stderr, $exit) = $ssh->cmd("chmod +x /test.sh"); +diag "Exit Code: $?"; +($stdout, $stderr) = $ssh->capture2("chmod +x /test.sh"); diag $stdout; diag $stderr; -diag $exit; -($stdout, $stderr, $exit) = $ssh->cmd("/test.sh > /test.log"); +diag "Exit Code: $?"; +($stdout, $stderr) = $ssh->capture2("/test.sh > /test.log"); diag $stdout; diag $stderr; -diag $exit; -($stdout, $stderr, $exit) = $ssh->cmd("cat /test.sh"); +diag "Exit Code: $?"; +($stdout, $stderr) = $ssh->capture2("cat /test.sh"); diag $stdout; diag $stderr; -diag $exit; -($stdout, $stderr, $exit) = $ssh->cmd("cat /test.log"); +diag "Exit Code: $?"; +($stdout, $stderr) = $ssh->capture2("cat /test.log"); diag $stdout; diag $stderr; -diag $exit; +diag "Exit Code: $?"; ok($stdout =~ /100% packet loss|Network is unreachable/, "packet loss expected"); shutdown_vm_gracefully($dom); diff --git a/scripts/nwfilter/220-no-ip-spoofing.t b/scripts/nwfilter/220-no-ip-spoofing.t index d447a19..872dcc3 100644 --- a/scripts/nwfilter/220-no-ip-spoofing.t +++ b/scripts/nwfilter/220-no-ip-spoofing.t @@ -31,7 +31,7 @@ use Test::More tests => 4; use Sys::Virt::TCK; use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; -use Net::SSH::Perl; +use Net::OpenSSH; use File::Spec::Functions qw(catfile catdir rootdir); @@ -71,9 +71,10 @@ diag $ebtable; ok($ebtable =~ "$guestip", "check ebtables entry"); # log into guest -my $ssh = Net::SSH::Perl->new($guestip); diag "ssh'ing into $guestip"; -$ssh->login("root", $tck->root_password()); +my $ssh = Net::OpenSSH->new($guestip, + user => "root", + password => $tck->root_password()); # now bring eth0 down, change IP and bring it up again diag "preparing ip spoof"; @@ -95,23 +96,23 @@ MASK=`ip addr show \\\$DEV | grep 'inet ' | awk '{print \\\$2}' | sed -e 's/.*\\ /sbin/ip addr show \\\$DEV" > /test.sh EOF diag $cmdfile; -my ($stdout, $stderr, $exit) = $ssh->cmd($cmdfile); +my ($stdout, $stderr) = $ssh->capture2($cmdfile); diag $stdout; diag $stderr; -diag $exit; -($stdout, $stderr, $exit) = $ssh->cmd("chmod +x /test.sh"); +diag "Exit Code: $?"; +($stdout, $stderr) = $ssh->capture2("chmod +x /test.sh"); diag $stdout; diag $stderr; -diag $exit; -($stdout, $stderr, $exit) = $ssh->cmd("cat /test.sh"); +diag "Exit Code: $?"; +($stdout, $stderr) = $ssh->capture2("cat /test.sh"); diag $stdout; diag $stderr; -diag $exit; +diag "Exit Code: $?"; diag "running ip spoof"; -($stdout, $stderr, $exit) = $ssh->cmd("/test.sh"); +($stdout, $stderr) = $ssh->capture2("/test.sh"); diag $stdout; diag $stderr; -diag $exit; +diag "Exit Code: $?"; diag "checking result"; ok($stdout =~ "100% packet loss", "packet loss expected"); diff --git a/scripts/nwfilter/230-no-mac-broadcast.t b/scripts/nwfilter/230-no-mac-broadcast.t index 9d00dc4..70c1ab4 100644 --- a/scripts/nwfilter/230-no-mac-broadcast.t +++ b/scripts/nwfilter/230-no-mac-broadcast.t @@ -31,7 +31,7 @@ use Test::More tests => 4; use Sys::Virt::TCK; use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; -use Net::SSH::Perl; +use Net::OpenSSH; use File::Spec::Functions qw(catfile catdir rootdir); my $tck = Sys::Virt::TCK->new(); @@ -85,9 +85,10 @@ diag "prepare tcpdump"; system("/usr/sbin/tcpdump -v -i virbr0 -n host 255.255.255.255 2> /tmp/tcpdump.log &"); # log into guest -my $ssh = Net::SSH::Perl->new($guestip); diag "ssh'ing into $guestip"; -$ssh->login("root", $tck->root_password()); +my $ssh = Net::OpenSSH->new($guestip, + user => "root", + password => $tck->root_password()); # now generate a mac broadcast paket diag "generate mac broadcast"; @@ -95,22 +96,22 @@ my $cmdfile = <<EOF; echo '/bin/ping -c 1 192.168.122.255 -b' > /test.sh EOF diag $cmdfile; -my ($stdout, $stderr, $exit) = $ssh->cmd($cmdfile); +my ($stdout, $stderr) = $ssh->capture2($cmdfile); diag $stdout; diag $stderr; -diag $exit; -($stdout, $stderr, $exit) = $ssh->cmd("chmod +x /test.sh"); +diag "Exit Code: $?"; +($stdout, $stderr) = $ssh->capture2("chmod +x /test.sh"); diag $stdout; diag $stderr; -diag $exit; -($stdout, $stderr, $exit) = $ssh->cmd("/test.sh > /test.log"); +diag "Exit Code: $?"; +($stdout, $stderr) = $ssh->capture2("/test.sh > /test.log"); diag $stdout; diag $stderr; -diag $exit; -($stdout, $stderr, $exit) = $ssh->cmd("cat /test.log"); +diag "Exit Code: $?"; +($stdout, $stderr) = $ssh->capture2("cat /test.log"); diag $stdout; diag $stderr; -diag $exit; +diag "Exit Code: $?"; # now stop tcpdump and verify result diag "stopping tcpdump"; diff --git a/scripts/nwfilter/240-no-arp-spoofing.t b/scripts/nwfilter/240-no-arp-spoofing.t index f1e6870..141fb92 100644 --- a/scripts/nwfilter/240-no-arp-spoofing.t +++ b/scripts/nwfilter/240-no-arp-spoofing.t @@ -31,7 +31,7 @@ use Test::More tests => 4; use Sys::Virt::TCK; use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; -use Net::SSH::Perl; +use Net::OpenSSH; use File::Spec::Functions qw(catfile catdir rootdir); my $spoofid = "192.168.122.183"; @@ -85,9 +85,10 @@ diag "prepare tcpdump"; system("/usr/sbin/tcpdump -v -i virbr0 not ip > /tmp/tcpdump.log &"); # log into guest -my $ssh = Net::SSH::Perl->new($guestip); diag "ssh'ing into $guestip"; -$ssh->login("root", $tck->root_password()); +my $ssh = Net::OpenSSH->new($guestip, + user => "root", + password => $tck->root_password()); # now generate a arp spoofing packets diag "generate arpspoof"; @@ -100,23 +101,23 @@ EOF diag "content of cmdfile:"; diag $cmdfile; diag "creating cmdfile"; -my ($stdout, $stderr, $exit) = $ssh->cmd($cmdfile); +my ($stdout, $stderr) = $ssh->capture2($cmdfile); diag $stdout; diag $stderr; -diag $exit; -($stdout, $stderr, $exit) = $ssh->cmd("chmod +x /test.sh"); +diag "Exit Code: $?"; +($stdout, $stderr) = $ssh->capture2("chmod +x /test.sh"); diag $stdout; diag $stderr; -diag $exit; +diag "Exit Code: $?"; diag "excuting cmdfile"; -($stdout, $stderr, $exit) = $ssh->cmd("/test.sh > /test.log"); +($stdout, $stderr) = $ssh->capture2("/test.sh > /test.log"); diag $stdout; diag $stderr; -diag $exit; -($stdout, $stderr, $exit) = $ssh->cmd("echo test.log\ncat /test.log"); +diag "Exit Code: $?"; +($stdout, $stderr) = $ssh->capture2("echo test.log\ncat /test.log"); diag $stdout; diag $stderr; -diag $exit; +diag "Exit Code: $?"; # now stop tcpdump and verify result diag "stopping tcpdump"; diff --git a/scripts/nwfilter/300-vsitype.t b/scripts/nwfilter/300-vsitype.t index 430618f..d169339 100644 --- a/scripts/nwfilter/300-vsitype.t +++ b/scripts/nwfilter/300-vsitype.t @@ -31,7 +31,6 @@ use Test::More; use Sys::Virt::TCK; use Sys::Virt::TCK::NetworkHelpers; use Test::Exception; -use Net::SSH::Perl; use File::Spec::Functions qw(catfile catdir rootdir); my $tck = Sys::Virt::TCK->new(); -- 2.13.6

The setting of the environment variable MASK was for some reason producing "8" instead of "24". Changing from using back-ticks "`" that resolved at the time the script was created, to using $(blah) resolved when the script is *run* magically fixed the problem. Note that this doesn't change the outcome of the test at all, since the guest never needs to connect outside the local subnet, and is immediately halted after setting the IP using $MASK. It just bothered me that the value was incorrect (and that backticks were being used, when $() is more portable - again it is duly noted that portability doesn't matter in this case, since we know that the script will always be executed on Fedora with bash). --- scripts/nwfilter/220-no-ip-spoofing.t | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/nwfilter/220-no-ip-spoofing.t b/scripts/nwfilter/220-no-ip-spoofing.t index 872dcc3..5903961 100644 --- a/scripts/nwfilter/220-no-ip-spoofing.t +++ b/scripts/nwfilter/220-no-ip-spoofing.t @@ -79,9 +79,10 @@ my $ssh = Net::OpenSSH->new($guestip, # now bring eth0 down, change IP and bring it up again diag "preparing ip spoof"; my $cmdfile = <<EOF; -echo "DEV=`ip link | head -3 | tail -1 | awk '{print \\\$2}' | sed -e 's/://'` -MASK=`ip addr show \\\$DEV | grep 'inet ' | awk '{print \\\$2}' | sed -e 's/.*\\///;q'` +echo "DEV=\\\$(ip link | head -3 | tail -1 | awk '{print \\\$2}' | sed -e 's/://') +MASK=\\\$(ip addr show \\\$DEV | grep 'inet ' | awk '{print \\\$2}' | sed -e 's/.*\\///;q') /sbin/ip addr show \\\$DEV +kill \\\$(pidof dhclient) /sbin/ip link set \\\$DEV down /sbin/ip addr flush dev \\\$DEV /sbin/ip addr add 192.168.122.183/\\\$MASK dev \\\$DEV -- 2.13.6

On Wed, Feb 07, 2018 at 09:04:54PM -0500, Laine Stump wrote: Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com&gt; Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

On Wed, Feb 07, 2018 at 09:04:55PM -0500, Laine Stump wrote: Err, wow. Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com&gt; Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

On Wed, Feb 07, 2018 at 09:04:56PM -0500, Laine Stump wrote: You could put "clean-traffic" here instead of the 'undef' which.... ....avoids need for any of these changes. This one is needed to override the default This one can be dropped Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

On Wed, Feb 07, 2018 at 09:04:57PM -0500, Laine Stump wrote: Reviewed-by: Daniel P. Berrange <berrange(a)redhat.com&gt; Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

The root account in the Fedora image used for the tests has a properly specified path, so the extra verbiage just clutters up the screen. --- scripts/nwfilter/210-no-mac-spoofing.t | 20 ++++++++++---------- scripts/nwfilter/220-no-ip-spoofing.t | 26 +++++++++++++------------- scripts/nwfilter/230-no-mac-broadcast.t | 2 +- scripts/nwfilter/240-no-arp-spoofing.t | 6 +++--- 4 files changed, 27 insertions(+), 27 deletions(-) diff --git a/scripts/nwfilter/210-no-mac-spoofing.t b/scripts/nwfilter/210-no-mac-spoofing.t index b4a4990..3438f4a 100644 --- a/scripts/nwfilter/210-no-mac-spoofing.t +++ b/scripts/nwfilter/210-no-mac-spoofing.t @@ -98,16 +98,16 @@ my $ssh = Net::OpenSSH->new($guestip, diag "fiddling with mac"; my $cmdfile = <<EOF; echo "DEV=`ip link | head -3 | tail -1 | awk '{print \\\$2}' | sed -e 's/://'` -/sbin/ip addr show dev \\\$DEV -/sbin/ip link set \\\$DEV down -/sbin/ip link set \\\$DEV address ${macfalse} -/sbin/ip link set \\\$DEV up -/sbin/ip addr show dev \\\$DEV -/bin/ping -c 10 ${gateway} 2>&1 -/sbin/ip link set \\\$DEV down -/sbin/ip link set \\\$DEV address ${mac} -/sbin/ip link set \\\$DEV up -/sbin/ip addr show dev \\\$DEV" > /test.sh +ip addr show dev \\\$DEV +ip link set \\\$DEV down +ip link set \\\$DEV address ${macfalse} +ip link set \\\$DEV up +ip addr show dev \\\$DEV +ping -c 10 ${gateway} 2>&1 +ip link set \\\$DEV down +ip link set \\\$DEV address ${mac} +ip link set \\\$DEV up +ip addr show dev \\\$DEV" > /test.sh EOF diag $cmdfile; my ($stdout, $stderr) = $ssh->capture2($cmdfile); diff --git a/scripts/nwfilter/220-no-ip-spoofing.t b/scripts/nwfilter/220-no-ip-spoofing.t index f3e4a38..9e1bb70 100644 --- a/scripts/nwfilter/220-no-ip-spoofing.t +++ b/scripts/nwfilter/220-no-ip-spoofing.t @@ -82,20 +82,20 @@ diag "preparing ip spoof"; my $cmdfile = <<EOF; echo "DEV=\\\$(ip link | head -3 | tail -1 | awk '{print \\\$2}' | sed -e 's/://') MASK=\\\$(ip addr show \\\$DEV | grep 'inet ' | awk '{print \\\$2}' | sed -e 's/.*\\///;q') -/sbin/ip addr show \\\$DEV +ip addr show \\\$DEV kill \\\$(pidof dhclient) -/sbin/ip link set \\\$DEV down -/sbin/ip addr flush dev \\\$DEV -/sbin/ip addr add 192.168.122.183/\\\$MASK dev \\\$DEV -/sbin/ip link set \\\$DEV up -/sbin/ip addr show \\\$DEV -/bin/sleep 1 -/bin/ping -c 1 192.168.122.1 -/sbin/ip link set \\\$DEV down -/sbin/ip addr flush dev \\\$DEV -/sbin/ip addr add ${guestip}/\\\$MASK dev \\\$DEV -/sbin/ip link set \\\$DEV up -/sbin/ip addr show \\\$DEV" > /test.sh +ip link set \\\$DEV down +ip addr flush dev \\\$DEV +ip addr add 192.168.122.183/\\\$MASK dev \\\$DEV +ip link set \\\$DEV up +ip addr show \\\$DEV +sleep 1 +ping -c 1 192.168.122.1 +ip link set \\\$DEV down +ip addr flush dev \\\$DEV +ip addr add ${guestip}/\\\$MASK dev \\\$DEV +ip link set \\\$DEV up +ip addr show \\\$DEV" > /test.sh EOF diag $cmdfile; my ($stdout, $stderr) = $ssh->capture2($cmdfile); diff --git a/scripts/nwfilter/230-no-mac-broadcast.t b/scripts/nwfilter/230-no-mac-broadcast.t index f05a9c2..758005c 100644 --- a/scripts/nwfilter/230-no-mac-broadcast.t +++ b/scripts/nwfilter/230-no-mac-broadcast.t @@ -91,7 +91,7 @@ my $ssh = Net::OpenSSH->new($guestip, # now generate a mac broadcast paket diag "generate mac broadcast"; my $cmdfile = <<EOF; -echo '/bin/ping -c 1 192.168.122.255 -b' > /test.sh +echo 'ping -c 1 192.168.122.255 -b' > /test.sh EOF diag $cmdfile; my ($stdout, $stderr) = $ssh->capture2($cmdfile); diff --git a/scripts/nwfilter/240-no-arp-spoofing.t b/scripts/nwfilter/240-no-arp-spoofing.t index 33febe9..dfc8e08 100644 --- a/scripts/nwfilter/240-no-arp-spoofing.t +++ b/scripts/nwfilter/240-no-arp-spoofing.t @@ -94,9 +94,9 @@ my $ssh = Net::OpenSSH->new($guestip, # now generate a arp spoofing packets diag "generate arpspoof script"; my $cmdfile = <<EOF; -echo "/usr/sbin/arpspoof ${spoofid} & -/bin/sleep 10 -kill -15 `/sbin/pidof arpspoof`" > /test.sh +echo "arpspoof ${spoofid} & +sleep 10 +kill -15 \\\$(pidof arpspoof)" > /test.sh EOF diag "content of cmdfile:"; -- 2.13.6