Re: [libvirt] [PATCH] qemu: fix fail to start vm with one cell use memdev and another not

On 16.01.2015 03:12, Luyao Huang wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1182467 > > We changed our build numa qemu cmd line way in f309db, > But qemu cannot accept one cell use memdev and another not, > so this cause a issue when we start a vm with one cell > have hugpage or nodemask settings and others not. > > After this patch we will use memdev for all cells if there > is at least one cell need this. > > Signed-off-by: Luyao Huang <lhuang(a)redhat.com&gt; > --- > src/qemu/qemu_command.c | 88 +++++++++++++--------- > .../qemuxml2argv-numatune-memnode-no-memory.args | 3 +- > 2 files changed, 55 insertions(+), 36 deletions(-) While I agree the bug you are trying to fix is real bug, the patch look a bit messy. Moreover, as far as I know Peter is doing work in this area and he's willing to fix the bug. You know, he's rewriting the area from scratch (or something like that), so I don't really want to cause a rebase conflict to him. Moreover, some tests fail after this patch, so I will not merge this for now, sorry.

Michal