Re: [libvirt] [PATCH] esx: Fix a potential crash

12 Jul 2011

于 2011年07月12日 16:58, Daniel Veillard 写道:
...
On Tue, Jul 12, 2011 at 05:05:16PM +0800, Osier Yang wrote:
...
Initialize ptr data.datastorePathWithoutFileName as NULL, otherwise
it might cause crash when trying to free it in cleanup.
---
  src/esx/esx_driver.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
index ddb8c23..ae614a6 100644
--- a/src/esx/esx_driver.c
+++ b/src/esx/esx_driver.c
@@ -2698,6 +2698,7 @@ esxDomainGetXMLDesc(virDomainPtr domain, unsigned int flags)
      char *vmx = NULL;
      virVMXContext ctx;
      esxVMX_Data data;
+    data.datastorePathWithoutFileName = NULL;
      virDomainDefPtr def = NULL;
      char *xml = NULL;
ACK,
Daniel
Thanks, applied

Osier

    