16 Apr
2019
16 Apr
'19
12:51 p.m.
On 4/16/19 4:58 AM, Andrea Bolognani wrote:
On Mon, 2019-04-15 at 19:09 -0400, Cole Robinson wrote: [...]
+ DO_TEST_CAPS_LATEST("virtio-transitional"); + DO_TEST_CAPS_LATEST("virtio-non-transitional");
We should also add
DO_TEST_CAPS_VER("virtio-transitional", "3.1.0"); DO_TEST_CAPS_VER("virtio-non-transitional", "3.1.0");
same as xml2argv. You can do that in a separate patch, though.
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Hmm I'm not sure if those bits will actually test any different code paths for xml2xml? I'd check coverage output but lcov is broken with gcc9 on f30 Anyways thanks for the reviews, I've pushed these now Thanks, Cole