Re: [libvirt] [PATCH 0/6] new virsh command "blkiotune" support

On Wed, Feb 16, 2011 at 11:53:06AM +0800, Gui Jianfeng wrote: > Hi All, > > This series implements a new command "blkiotune" for virsh. > A lot of code borrows from memtune. > You are able to tune blkio cgroup tunables by this command as follows. > > Show tunables > #virsh blkiotune My_guest > weight : 900 > > Tune tunables(Set IO weight) > #virsh blkiotune My_guest --weight 500 > #virsh blkiotune My_guest > weight : 500 Okay, I reviewed the patch set, it looks okay to me, one could discuss the need to go for something as generic a parameters for memeory when there is only one parameter (right now) but since this is likely to expand in the future, that's fine. I suggest you rebase your patch set to the current git head, fix for example src/libvirt_public.syms since we are past 0.8.8, and drop any mention of cgroup in the comments or documentation since that API is generic and doesn't need to be tied to that specific implentation used for QEmu, for example if there is something equivalent to tune Block I/Os in VMWare it's very unlikely to be based on cgroups :-)

thanks ! Daniel