Re: [libvirt-python PATCH v3 2/3] gitlab: introduce CI jobs testing git master & distro libvirt
On Fri, 2020-05-01 at 10:20 +0100, Daniel P. Berrangé wrote:
+.build_git_job_template: &build_git_job_definition
+ image: $CI_REGISTRY_IMAGE/ci-$NAME:latest
+ stage: builds
This should be git_build_job_template...
+.build_dist_job_template: &build_dist_job_definition
+ image: $CI_REGISTRY_IMAGE/ci-$NAME:latest
+ stage: builds
... and this should be dist_build_job_template now, with all uses
below updated accordingly of course.
+++ b/ci/README.rst
@@ -0,0 +1,13 @@
+CI job assets
+=============
+
+This directory contains assets used in the automated CI jobs, most
+notably the Dockerfiles used to build container images in which the
+CI jobs then run.
+
+The ``refresh`` script is used to re-create the Dockerfiles using the
+``lcitool`` that is provided by repo https://gitlab.com/libvirt/libvirt-ci
This should read either "the lcitool command", or "the lcitool
script", or something else along those lines.
With these last remaining nits addressed,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
I still don't feel comfortable ACKing the first patch, but you can
look at it this way: once you've pushed the last two patches, the
first one will suddenly fall squarely under the CI fix rule ;)
--
Andrea Bolognani / Red Hat / Virtualization