On 12/12/2011 04:39 PM, Michael Ellerman wrote:
We can't call qemuCapsExtractVersionInfo() from test code,
because it
expects to be able to call the emulator, and for testing we have fake
emulators that can't be executed. For that reason qemuxml2argvtest.c
doesn't call qemuDomainAssignPCIAddresses(), instead it open codes its
own version.
That means we can't call qemuDomainAssignAddresses() from the test code,
instead we need to manually call qemuDomainAssignSpaprVioAddresses().
Also add logic to cope with qemuDomainAssignSpaprVioAddresses() failing,
so that we can write a test that checks for a known failure in there.
Signed-off-by: Michael Ellerman <michael(a)ellerman.id.au>
---
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_command.h | 1 +
tests/qemuxml2argvtest.c | 18 +++++++++++++-----
3 files changed, 15 insertions(+), 6 deletions(-)
I wasn't sure if we needed to list qemuDomainAssignSpaprVioAddresses in
the .syms file for export; so I did a cross-build to mingw, and things
still linked. Which means I think we got away without needing it.
ACK and pushed.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org