Re: [libvirt] [PATCH 0/3] Remove deprecated pc-0.x machine types and related hacks
On 06/12/2019 07.49, Markus Armbruster wrote:
Thomas Huth <thuth(a)redhat.com> writes:
> These have been on the deprecation list since a year now, so it's
> time to finally remove the pc-0.x machine types.
>
> We then can also remove some compatibility hacks in the devices, i.e.
> the "use_broken_id" in ac97 and "command_serr_enable" in PCI
devices.
>
> Note that there is also the "rombar" property of the PCI devices which
> is now not required for the x86 machine types anymore. But it seems to
> me like this is still used by various people to bypass the ROM loading
> for PCI devices in certain cases, so I did not remove that property here
> yet.
With this series applied:
$ git-grep pc-0
hw/display/vga-pci.c: /* compatibility with pc-0.13 and older */
hw/display/vga.c: /* With pc-0.12 and below we map both the PCI BAR and the fixed VBE
region,
hw/display/vmware_vga.c: /* compatibility with pc-0.13 and older */
These are the "rombar" hacks that I've mentioned above. The question is
whether we want to remove them or whether I should just adjust the comments?
hw/i386/pc_piix.c:/* PC compat function
Right, the comment still needs to be adjusted.
Thomas