Re: [libvirt] [PATCH 1/1] Support for RDP

On Thu, Apr 16, 2009 at 11:21:23AM +0200, Pritesh Kothari wrote: So, summarizing your suggested XML syntax, it more or less looked like this: <graphics type='rdp' port='12345' listen='172.21.4.3' autoport='no' headless='yes' reuseConnection='yes' allowMultiConnections='yes' auth='external' authtimeout='1234'/> Historically with Xen and QEMU there has only been ability to have either SDL graphics, or VNC graphics, but not both. With VirtualBox you can actually have the local desktop window *and* RDP at the same time, or just the local desktop, or just RDP, or neither. There seems to be a SDL graphics mode too, but the docs says that's only really for developers, and it doesn't look to be exposed in the API This really says to me that we should represent the virtualbox graphics configuration with 2 separate <graphics> tags, one for the local desktop display config, and one for the RDP config. <graphics type='desktop'/> <graphics type='rdp' port='1234' autoport='no' listen='172.21.4.3'/> If RDP is not enabled, then don't include the 2nd. If the local desktop display is not enabled, then don't include the 1st. This avoids the the 'headless' attribute being exposed in the XML directly. I chose type='desktop' as representing the 'native' desktop app display of the virt technology in question. I imagine it'll take similar attributes to the type=sdl, while the type=rdp would be similar to type=vnc. For the allowMultiConnection & reuseSingleConnection attributes, I think i'd prefer something a little less verbose as the XML attribute names. How about multiUser='yes|no' (for allowMultiConnection) replaceUser='yes|no' (for reuseSingleConnection) For the local desktop window, is there any way in the API to indicate what X display it should be shown on ? Obviously if launched within a desktop session it'll display on that session. If I ssh into a remote machine though, currently virtualbox libvirt driver will start the display on the $DISPLAY from the forwarded SSH session virsh is running in which isn't really what I wanted. I think we really need to be able to indicate a desired X $DISPLAY (or equiv) in the XML for the local desktop window graphics mode, eg, akin to the current SDL config we could have <graphics type='desktop' display=':0.0'/> Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|