On 10/11/2018 11:40 AM, Fabiano Fidêncio wrote:
The first patch is needed to properly support Q35 machine type on GNOME Boxes (or any other app using libvirt-glib) as the ICH9 audio device should be used together with Q35 machine type,
The second patch is mostly a convenience for the apps and the third one just adds a test case for the second.
Fabiano Fidêncio (3): gconfig-domain-sound: Add ich9 sound device gconfig: add _domain_os_get_machine() tests: Add testes for _domain_os_{set,get}_machine()
libvirt-gconfig/libvirt-gconfig-domain-os.c | 7 +++++++ libvirt-gconfig/libvirt-gconfig-domain-os.h | 1 + libvirt-gconfig/libvirt-gconfig-domain-sound.h | 3 ++- libvirt-gconfig/libvirt-gconfig.sym | 1 + tests/test-gconfig.c | 2 ++ tests/xml/gconfig-domain-os.xml | 2 +- 6 files changed, 14 insertions(+), 2 deletions(-)
Reviewed-by: Cole Robinson <crobinso@redhat.com> - Cole