Re: [libvirt] PATCH: 17/25: Concurrent client dispatch in libvirtd
On Mon, Jan 19, 2009 at 05:13:35PM -0500, Dave Allan wrote:
Daniel P. Berrange wrote:
>>>+qemudClientMessageQueuePop(struct qemud_client_message **queue)
>The daemon needs a FIFO queue for fairness, so removing from head
>is correct. To avoid confusion with Perl's push/pop/shift/unshift
>semantics I should rename this Pop method to Shift instead.
Just my $.02, how about qemudClientMessageEnqueue and
qemudClientMessageDequeue? I associate push and pop with stacks, not
queues.
Well this is just my perl mind thinking, where stacks & queues are one
and the same - the 4 core operators allow either model, or a combo of
both.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|