Re: [libvirt] [PATCH 01/13] qemu: fix use-after-free when parsing NBD disk
On 02/27/2013 10:03 PM, Eric Blake wrote:
So there is definitely a use-after-free bug fixed by your patch.
However, your patch causes a double-free bug on error (if the
Rather, your patch did nothing to address the pre-existing double-free
bug on error. Guess I should be more careful when pinning the blame :)
strdup(port) fails, then disk->hosts->port and disk->src are
the same
pointer, but we attempt to free both of them).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)