Re: [libvirt] [PATCH 07/14] secret: Move virSecretObjListGetUUIDs

On 04/25/2017 08:42 AM, Pavel Hrdina wrote: > On Tue, Apr 25, 2017 at 08:00:26AM -0400, John Ferlan wrote: >> >> >> On 04/25/2017 04:39 AM, Pavel Hrdina wrote: >>> On Mon, Apr 24, 2017 at 02:00:16PM -0400, John Ferlan wrote: >>>> Move code closer to usage. >>> >>> NACK, the function is exported so the usage is not only inside this file. >>> In addition it adds an extra step while tracing the history of the code. >>> >>> Pavel >>> >> >> While I don't agree, but I can drop this - again, in patches not yet >> posted it's a lot easier to read the code with the GetUUIDs closer to >> what GetHelper (or what it becomes by patch9). > > I thing that it's OK to have both *Callback functions next to each other > followed by the virSecretObjListNumOfSecrets and virSecretObjListGetUUIDs > next to each other. > Exactly, but you NACK'd the code motion. Now I'm confused.

BTW: After this patch the order is: virSecretObjListGetHelper <= Used for both NumOf and GetUUIDs virSecretObjListNumOfSecrets <= API virSecretObjListGetUUIDs <= API virSecretObjMatchFlags <= Used by ListPopulate virSecretObjListPopulate <= Used by ListExport virSecretObjListExport <== API John > Pavel > >> >> >> John >> >> -- >> libvir-list mailing list >> libvir-list(a)redhat.com >> https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list