Re: [libvirt] [PATCH] OpenVZ xml refactoring
On Mon, Jul 28, 2008 at 10:12:49AM -0400, Daniel Veillard wrote:
On Mon, Jul 28, 2008 at 05:38:47PM +0400, Evgeniy Sokolov wrote:
>
> >On Fri, Jul 25, 2008 at 04:44:09PM +0400, Evgeniy Sokolov wrote:
> > In general that looks way cleaner to me,
> >I will give it a few nmore days and apply, unless you suggest another
> >version,
>
> fixed patch is attached.
Okay, I applied and commited this because it enforces the transition to
the new XML format for OpenVZ and any such change should be done as soon
as possible. But Dan's point remain, we need to transition to the new
reading routines, and virDomainNetDefParseXML will have to be made static
again when done. But as I understand you agree with this so it's just an
intermediate state of the code :-)
This patch doesn't work or compile because it is missing an argument
to virXPathNodeSet(). Please make sure you're developing against the
latest CVS checkout of libvirt when submitting patches, and run the
configure script with the '--enable-compile-warnings=error' argument
the catch this sort of problem before submission.
Here is the nightly build failure in question:
http://builder.virt-manager.org/logs/modules/libvirt--devel-build-output.log
Regards,
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|