Re: [PATCH] conf: virtiofs: add rlimit_nofile element
On Tue, Jul 16, 2024 at 11:40:36AM +0200, Adam Julis wrote:
Add an element to configure the rlimit nofile size:
...
<binary>
<rlimit_nofile size='122333'/>
</binary>
I think this XML design is sub-optimal in a number of ways
* "rlimit" is an implementation detail which is
something we hide from XML generally
* "nofile" is a terrible historic UNIX naming choice which
we shouldn't reuse IMHO.
* The extra "size" attribute is redundant given the "no"
in "nofile"
How about we change this before release to something like
<max_files>123458</max_files>
Or
<openfiles max="123456"/>
Or
<openfiles limit="123456"/>
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index ca33a2a570..10584dfe83 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -3734,6 +3734,10 @@ A directory on the host that can be accessed directly from the
guest.
The thread pool helps increase the number of requests in flight when used with
storage that has a higher latency. However, it has an overhead, and so for
fast, low latency filesystems, it may be best to turn it off. ( :since:`Since 8.5.0`
)
+ Element ``rlimit_profile`` accepts one attribute ``size`` which defines the
"rlimit_profile" is not the element name
+ maximum number of file descriptors. Non-positive values are
forbidden.
+ Although numbers greater than 1M are allowed, the virtiofsd documentation
+ states that in this case its set by virtiofsd to the 1M. ( :since:`Since 10.6.0` )
We shouldn't list current point-in-time limitations of current backend
driver impl in the XML schema.
IOW, rather than saying 1M is a limit, we should be saying
"The upper bound on the number of open files is implementation defined"
``source``
The resource on the host that is being accessed in the guest. The ``name``
attribute must be used with ``type='template'``, and the ``dir`` attribute
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|