On Fri, Jun 26, 2015 at 11:06:01AM +0200, Martin Kletzander wrote:
On Fri, Jun 26, 2015 at 09:51:26AM +0100, Daniel P. Berrange wrote:
>On Thu, Jun 25, 2015 at 09:50:42PM +0200, Martin Kletzander wrote:
>>[adding Dan to Cc as he asked me about this right before I had to
>>leave for an appointment]
>>
>>On Thu, Jun 25, 2015 at 10:08:10PM +0800, Daniel Veillard wrote:
>>> Sorry I nearly forgot, but we should enter freeze soon to try to
>>>hit the end of the month target. I see that Martin's APIs for admin
support
>>>has been merged in so that would be libvirt-1.3.0.
>>
>>Sorry from me too, but I planned to merge the admin API earlier so we
>>can finish the design of first APIs. Unfortunately, everything got
>>prolonged and we're right before the freeze with only Open and Close
>>APIs. And because I really dislike when we create APIs that return
>>"unsupported" just so we have them in, I'd be in favour for rather
>>adding one useful API instead of 5 non-working ones. The other option
>>is to conditionally disable the code for Admin API just for the
>>release and bump the minor version for the next release when we have
>>some useful stuff in.
>
>I'd probably vote for just disabling the build of the libvirt-admin.so
And keep the admin server in the daemon?
Well we could just stop it listening on the socket too.
>library, instead of rushing to add an API. Of course that'd make our
>version number bump amuzing, but I don't particular worry about that
>as honestly the numbers are fairly meaningless anyway ;-)
>
Me too. But changing the version back is just a matter of reverting
commit 9a8d916e89173890d7f7ce538b1ab781192b8440 and changing circa 2
more lines. I'll send the admin-deferring patches in a while so we
can continue the discussion there.
Regards,
Daniel
--
|:
http://berrange.com -o-
http://www.flickr.com/photos/dberrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|:
http://entangle-photo.org -o-
http://live.gnome.org/gtk-vnc :|