Re: [PATCH 02/23] vsh: Don't translate error messages for 'self-test'
On Tue, Mar 12, 2024 at 05:41:15PM +0100, Ján Tomko wrote:
On a Monday in 2024, Peter Krempa wrote:
> The command invoking the code is internal and meant for developers,
> there's no point in translating the errors.
>
I would have expected this change to trigger syntax-check errors,
but it seems we stopped checking for vshError translations back in 2008:
commit 513bd04ce1d443cbaba9acbfcf6865746c4f513a
Mark many more strings for translation.
That's surely a mistake in the regex refactoring we should fix ?
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
> tools/vsh.c | 51 ++++++++++++++++++++++++++-------------------------
> 1 file changed, 26 insertions(+), 25 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
_______________________________________________
Devel mailing list -- devel(a)lists.libvirt.org
To unsubscribe send an email to devel-leave(a)lists.libvirt.org
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|