On Tue, Apr 17, 2018 at 12:41:09PM +0200, Andrea Bolognani wrote:
On Tue, 2018-04-17 at 11:19 +0100, Daniel P. Berrangé wrote:
On Tue, Apr 17, 2018 at 12:13:01PM +0200, Andrea Bolognani wrote:
Do you want me to send v2, or can I just squash this in and push?
Fine to squash it unless you notice something complicated needs furtehr changing.
Hm, Jenkins Job Builder is actually not happy with that:
ERROR:jenkins_jobs.parser:Duplicate definitions for job 'libvirt-master-build' specified
which makes sense because generic-build-jobs has
name: '{name}-{branch}-build'
I could trick it into using a different name with
- generic-build-job: name: libvirt-website ...
but then it would try to fetch new revisions from
git://n64.pufty.ci.centos.org/libvirt-website.git
which of course doesn't exist...
Given the situation, my original approach might be the best solution to the problem after all. What's your take?
Hmm, this is a problem with us repurposing 'name' as a parameter for the template, when it is also a declared field. eg the core issue is this: name: '{name}-{branch}-build' We should address this by changing the parameter name to be 'projname', so it doesn't clash with the official 'name' field used as the job name. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|