Re: [libvirt] [PATCH 3/7] node_device: detect CCW devices

> > ... > >> diff --git a/tests/nodedevschemadata/ccw_0_0_10000-invalid.xml >> b/tests/nodedevschemadata/ccw_0_0_10000-invalid.xml >> new file mode 100644 >> index 000000000..d840555c0 >> --- /dev/null >> +++ b/tests/nodedevschemadata/ccw_0_0_10000-invalid.xml >> @@ -0,0 +1,10 @@ >> +<device> >> + <name>ccw_0_0_10000</name> >> + <path>/sys/devices/css0/0.0.0000/0.0.10000</path> >> + <parent>computer</parent> >> + <capability type='ccw'> >> + <cssid>0x0</cssid> >> + <ssid>0x0</ssid> >> + <devno>0x10000</devno> >> + </capability> >> +</device> > > I assume you planned to use this, but either forgot or didn't want to > write the EXPECT_FAIL test? Since we don't perform any validation in the code, a test would never actually fail. But this XML is implicitly tested by virschematest so I thought at least this is covered. > > Should it be removed from the patch? Depends on if we actually want the validation and/or if the test against the RNG schema is enough.