Re: [libvirt] [PATCH 1/2] Make virNetDevSetupControl() public.

On 05/15/2013 11:47 PM, Roman Bogorodskiy wrote: > This method is useful not only in virnetdev.c. > --- > src/libvirt_private.syms | 1 + > src/util/virnetdev.c | 15 +++++++++++++-- > src/util/virnetdev.h | 12 ++++++++++++ > src/util/virnetdevmacvlan.c | 2 +- > src/util/virnetdevvportprofile.c | 2 +- > 5 files changed, 28 insertions(+), 4 deletions(-) > > +#else > +int > +virNetDevSetupControl(const char *ifname ATTRIBUTE_UNUSED, > + void *ifr ATTRIBUTE_UNUSED) > +{ > + virReportSystemError(ENOSYS, > + _("%s is not supported on this platform"), > + __func__); virReportSystemError is already a macro that reports the function name, so your message would include the name twice. But offhand, I can't think of any better wording to use.