Re: [libvirt] [libvirt-glib] Add wrapper for volume deletion API

2 Dec 2011


      On Fri, Dec 2, 2011 at 6:34 PM, Christophe Fergeau <cfergeau@redhat.com> wrote:
...
On Fri, Dec 02, 2011 at 05:34:15PM +0200, Zeeshan Ali (Khattak) wrote:
...
From: "Zeeshan Ali (Khattak)" <zeeshanak@gnome.org>
+    if (virStorageVolDelete(vol->priv->handle, flags) < 0) {
+        g_set_error (err,
+                     GVIR_STORAGE_VOL_ERROR,
+                     0,
+                     "Unable to delete storage volume");
I think gvir_error_new_literal should be used here
g_set_error() checks if error is NULL and doesn't set the error if so.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124