Re: [libvirt] [PATCH 1/2] tests: Fix use of virtio-serial for aarch64/virt
On Fri, Aug 31, 2018 at 04:03:09PM +0200, Andrea Bolognani wrote:
virtio-serial is an alias for virtio-serial-pci, which
should not have been used for a PCIe-less aarch64/virt
guest but it ended up being used anyway because the
I tried using the XML file with DO_TEST_CAPS_ARCH_LATEST
and it resulted in a pcie-root-port being added.
It seems all the capability files in our tests/qemucapabilities already
support gpex-pcihost, so adding a test using contemporary capabilites
might be worthwhile.
virtio-mmio capability was missing and the algorithm
is buggy.
Fix the test case so that we can fix the algorithm next.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
tests/qemuxml2argvdata/mach-virt-console-virtio.args | 2 +-
tests/qemuxml2argvtest.c | 3 ++-
tests/qemuxml2xmloutdata/mach-virt-console-virtio.xml | 4 +++-
tests/qemuxml2xmltest.c | 6 ++++--
4 files changed, 10 insertions(+), 5 deletions(-)
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
Jano
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)