Re: [libvirt] [PATCH 2/4] qemu: Check QEMU_CAPS_OBJECT_IOTHREAD for qemuDomainPinIOThread
On Tue, Oct 13, 2015 at 18:33:26 -0400, John Ferlan wrote:
On 10/13/2015 12:10 PM, Peter Krempa wrote:
> On Tue, Oct 13, 2015 at 11:47:08 -0400, John Ferlan wrote:
...
> Here this function should return that the iothread could not be
found as
> such VM shouldn't allow any iothreads if we don't support them.
>
>
I think it's preferable to have consistent error messages. See
qemuDomainGetIOThreadsLive and qemuDomainChgIOThread.
Giving a message such as iothread could not be found is I believe
misleading.
It is not misleading. It's true. In the configuration described you
can't have any iothreads so a message that you don't have any is spot
on.
Peter
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)