Re: [libvirt] [PATCH v7 6/7] qemu: add cache for DomainMemoryStats
On Wed, Jul 27, 2016 at 01:09:38PM +0200, Pavel Hrdina wrote:
On Wed, Jul 13, 2016 at 01:42:17PM +0300, Derbyshev Dmitriy wrote:
> From: Igor Redko <redkoi(a)virtuozzo.com>
>
> Communication with qemu monitor is time-consuming and there is
> additional overhead for converting qemu_binary->json->libvirt_binary.
>
> This patch tries to avoid unnecessary qmp queries.
> Knowing period of balloon statistics update cycle and timestamps of last update
> provided by qemu, it is possible to make cache of last response and reuse it
> for next requests.
I don't think that this is necessary. It doesn't take that much time to get the
memory stats and if someone want's to spam libvirt about those stats, well it's
pointless. NACK from me to this patch and the last one, but let's see if
someone else has a different opinion.
Yeah, I don't really see a need for this. The stats refresh period is
exposed in the XML, so an application using libvirt can simply avoid
calling this libvirt API more frequently than the configured stats
period.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|