Re: [libvirt PATCH 0/6] Clean up some includes
On Mon, Aug 03, 2020 at 12:24:18AM +0200, Ján Tomko wrote:
Ján Tomko (6):
util: virstring.h: remove stdarg.h include
hyperv: include virxml.h
util: viruri: move libxml include
util: log: move virLogMessage
util: virlog: unexport virLogVMessage
tools: remove unnecessary includes
This will always be an issue in such C code unless we use something that
includes all includes (or at least a group of them). We'd have `util.h` for
everything from `src/util/`, `conf.h` for everything from `src/conf/` and few
others. Until then there will be leftovers.
Anyway,
Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com>
src/hyperv/hyperv_wmi.c | 1 +
src/libvirt_private.syms | 1 -
src/util/virlog.c | 66 +++++++++++++++++----------------
src/util/virlog.h | 9 -----
src/util/virstring.h | 2 -
src/util/viruri.c | 2 +
src/util/viruri.h | 2 -
tools/virsh-domain-monitor.c | 2 -
tools/virsh-domain.c | 4 --
tools/virsh-host.c | 5 +--
tools/virsh-host.h | 2 +-
tools/virsh-interface.c | 4 --
tools/virsh-network.c | 2 -
tools/virsh-nodedev.c | 1 -
tools/virsh-nwfilter.c | 1 -
tools/virsh-secret.c | 1 -
tools/virsh-secret.h | 2 +-
tools/virsh-snapshot.c | 2 -
tools/virsh-snapshot.h | 2 +-
tools/virsh-volume.c | 2 -
tools/virsh.h | 2 -
tools/virt-admin-completer.c | 1 -
tools/virt-admin.c | 4 +-
tools/virt-host-validate-qemu.c | 1 -
tools/vsh-table.c | 2 -
tools/vsh.c | 3 --
tools/vsh.h | 2 -
27 files changed, 44 insertions(+), 84 deletions(-)
--
2.26.2
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)