On Tue, Jul 28, 2020 at 12:24:56PM +0200, Ján Tomko wrote:
On a Tuesday in 2020, Daniel P. Berrangé wrote:
On Tue, Jul 28, 2020 at 10:00:20AM +0200, Pavel Hrdina wrote:
3) Keep the patches as they are but error out in meson until the conversion is complete. The error can be used to detect if git bisect is withing the meson rewrite.
Pros: - full history of changes where each commit removes the relevant bits from autotools
- git bisect is not broken if failed compilation is not an issue and marked as git bisect skip
Cons: - meson build will fail and there is no autogen.sh so no way how to compile libvirt even partially
- script used for git bisect will have to skip failed compilation with an option to check for specific error
..So explicitly failing the meson build is a significant improvement.
We could have
- Meson build is forced to fail out of the box - An option "force_incomplete_build" to turn off the fail - When failing prints an error message
"This commit is part of the meson conversion and does not build a complete libvirt. If bisecting, use "git bisect skip" to continue, or "-Dforce_incomplete_build=true" to perform a partial build"
For unattended bisects, it would be nice to return 125 which is the magic value meaning 'skip' to 'git bisect run'.
I don't think its possible to force the ninja/meson exit status upon failure. I think at best uou could have a wrapper script "mymeson" that looks for this error message and returns 125. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|