Re: [libvirt] [PATCH 5/8] virVMXParseConfig: Don't leak def->videos
On Fri, Aug 04, 2017 at 04:22:33PM +0200, Michal Privoznik wrote:
This function calls virDomainDefAddImplicitDevices() which adds
implicit video device to domain definition. However, later in the
process the function just ignores this and overwrites the @videos
array without prior free.
We should not be calling virDomainDefAddImplicitDevices before
all the explicit devices are added to the domain definition.
What is the point of adding a device just to free it a few lines later?
Jan
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/vmx/vmx.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)