Re: [libvirt] [libvirt-rust PATCH 1/1] Make creating safe wrapper from raw pointer unsafe
On Wed, Sep 25, 2019 at 04:36:16PM +0000, Linus Färnstrand wrote:
Giving an invalid pointer to the safe wrapper types causes
undefined behavior when methods are later called on said wrapper
Properly document safety contract of using unsafe constructor
---
Ideally it should not be exposed at all because there already is a method for
getting the proper structure. And that method (or those methods) already use ::new() so
with this patch it just fails. Tests, examples, etc. Instead of fixing that I would,
probably, just not expose them. I don't see a reason for them being public.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)