Re: [libvirt] [PATCH] Use camelCase for XML attribute numQueues
On 04/18/2013 03:02 AM, Martin Kletzander wrote:
In commit d4bf0a9, we used num_queues for an attribute in the XML,
but
the consensus is that we use camelCase for that. Since there was no
release yet (the above commit describes as v1.0.4-65-gd4bf0a9), we
still have time to change it.
You may want to wait for DV's opinion on naming, but I wasn't aware that
we had a consensus on camelCase. In fact, '_' is currently winning,
although it's hard to say whether that is limited to older interfaces.
$ prefix='\(attribute\|element\) name=.[^'\''"]*'
$ git grep "${prefix}[A-Z]" docs/schemas/ | wc
14 42 977
$ git grep "${prefix}-" docs/schemas/ | wc
29 87 1925
$ git grep "${prefix}_" docs/schemas/ | wc
45 135 3075
But I personally don't like _, and think camelCase or - is nicer, so I
could live with this change if we get consensus.
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
This patch applies on top of Laine's RNG tightening patch [1] and it
was proposed in that thread as well.
[1] http://www.redhat.com/archives/libvir-list/2013-April/msg01320.html
---
docs/formatdomain.html.in | 2 +-
docs/schemas/domaincommon.rng | 2 +-
src/conf/domain_conf.c | 6 +++---
src/qemu/qemu_command.c | 2 +-
tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-scsi-num_queues.xml | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
The patch is accurate, but I don't want to give ACK without more
agreement on what naming convention we want for new XML (we should
probably patch HACKING to enforce a style if we have consensus). You
are correct that once 1.0.5 is released it will be too late to change,
so now is the time to decide.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)