Re: [libvirt] [PATCH v2] [TCK] nwfilter: probe for inverted ctdir

On 05/16/2013 10:02 AM, Stefan Berger wrote: > Linux netfilter at some point inverted the meaning of the '--ctdir reply' > and newer netfilter implementations now expect '--ctdir original' > instead and vice-versa. > We probe for this netfilter change via an IMCP message over loopback and 3 > filtering rules applied to INPUT. If the sent byte arrives, the newer > netfilter implementation has been detected and we convert the strings > in the iptables output to now match that inversion implemented by libvirt. > > The downside of this is that probing of libvirt and this test tool are > independent and this test tool will only work correctly for all cases > if used with libvirt probing for 'ctdir inversion' as well. Such is life - running newer TCK against older libvirt will thus potentially expose the bugs in that older libvirt, unless it is also on the older kernel. > > Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com&gt; > > --- > scripts/nwfilter/nwfilter2vmtest.sh | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) ACK.