Re: [libvirt] [PATCH 2/2] netcf backend for virInterface*.

On Tue, Jul 07, 2009 at 02:40:26AM -0400, Laine Stump wrote: Patch is fine, except: 1/ it misses an export of symbols to add some of the new private entry points to the list (trivial to fix see attached patch) 2/ unfortunately since there is no test driver for the Interface stuff, running make check tries to access the system running libvirtd, and that's a blocker to commit (it can turn especially frustrating if you don't want to give the root passwd to the repeating prompts !) So we need to commit first a test driver for the interface driver (dummy entry points should be sufficient), before pushing that last patch Courage it's nearly there ! :-) thanks, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/