On Fri, Feb 15, 2008 at 05:11:03PM +0100, Jim Meyering wrote:
+static const char *virStorageBackendDiskVolFormatToString(virConnectPtr conn, + int format) { + switch (format) { + case VIR_STORAGE_VOL_DISK_NONE: + return "none"; + case VIR_STORAGE_VOL_DISK_LINUX: + return "linux"; + case VIR_STORAGE_VOL_DISK_FAT16: + return "fat16"; + case VIR_STORAGE_VOL_DISK_FAT32: + return "fat32"; + case VIR_STORAGE_VOL_DISK_LINUX_SWAP: + return "swap"; + case VIR_STORAGE_VOL_DISK_LINUX_LVM: + return "lvm"; + case VIR_STORAGE_VOL_DISK_LINUX_RAID: + return "raid"; + case VIR_STORAGE_VOL_DISK_EXTENDED: + return "extended"; + }
Hi Dan,
I suppose the above functions should have the same strings and enum values? If so, the strings for the three VIR_STORAGE_VOL_DISK_LINUX_* enums in the latter need to match the "linux-..." prefixed ones above.
Yes, good catch - they definitely need the linux- prefix Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|