Re: [Libvir] PATCH: 14/16: disk partition backend

> +static const char *virStorageBackendDiskVolFormatToString(virConnectPtr conn, > + int format) { > + switch (format) { > + case VIR_STORAGE_VOL_DISK_NONE: > + return "none"; > + case VIR_STORAGE_VOL_DISK_LINUX: > + return "linux"; > + case VIR_STORAGE_VOL_DISK_FAT16: > + return "fat16"; > + case VIR_STORAGE_VOL_DISK_FAT32: > + return "fat32"; > + case VIR_STORAGE_VOL_DISK_LINUX_SWAP: > + return "swap"; > + case VIR_STORAGE_VOL_DISK_LINUX_LVM: > + return "lvm"; > + case VIR_STORAGE_VOL_DISK_LINUX_RAID: > + return "raid"; > + case VIR_STORAGE_VOL_DISK_EXTENDED: > + return "extended"; > + } Hi Dan, I suppose the above functions should have the same strings and enum values? If so, the strings for the three VIR_STORAGE_VOL_DISK_LINUX_* enums in the latter need to match the "linux-..." prefixed ones above.