Re: [libvirt] [PATCH 3/3] tests: check domain XML to libxl structures conversion

On 06/29/2017 02:11 AM, Marek Marczykowski-Górecki wrote: > libxl contains a method to dump libxl_domain_config in json format, > which is really convenient for tests. Unfortunately it require > libxl_ctx, which can be only created when running on Xen (wither in dom0 > or domU). Because of this, skip the test in other cases. > > For now, have just two tests, including just-introduced CPUID handling, > but this commit introduces a framework for further tests of > src/libxl/libxl_conf.c file. There's related work about this. You might wanna look at the recent Jim's series (CC'in him) from a few months ago (see below). He ressurected danpb work on these xml <-> libxl_domain_config conversion, and had a whole test suite for that where your cpuid test would be better inserted? Patch series is here: https://www.redhat.com/archives/libvir-list/2017-February/msg01477.html