On Wed, 2018-11-28 at 21:45 +0000, infos@nafets.de wrote:
From: Stefan Schallenberg <nafets227@users.noreply.github.com>
The above line is kinda weird: I would expect the email address to match the one in your R-b below. It looks like you might have misconfigured git on your system. I can fix it before pushing without you having to send another respin, assuming you're okay with that. [...]
@@ -3260,6 +3260,7 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def, addPCIRoot = true; break;
+ case VIR_ARCH_ARMV6L: case VIR_ARCH_ARMV7L: case VIR_ARCH_AARCH64: addDefaultUSB = false; @@ -3305,7 +3306,6 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def, addPCIRoot = true; break;
- case VIR_ARCH_ARMV6L: case VIR_ARCH_ARMV7B: case VIR_ARCH_CRIS: case VIR_ARCH_ITANIUM:
The two hunks above are unnecessary, since you're going to add proper VIR_ARCH_ARMV6L handling in the following commit. I'll drop them before pushing and deal with the merge conflict. Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization