On Thu, Apr 02, 2009 at 02:18:39PM -0400, laine@laine.org wrote:
From: Laine Stump <laine@redhat.com>
--- include/libvirt/libvirt.h | 18 ++ include/libvirt/libvirt.h.in | 18 ++ include/libvirt/virterror.h | 4 + src/datatypes.h | 25 ++ src/driver.h | 73 +++++ src/libvirt.c | 628 ++++++++++++++++++++++++++++++++++++++++++ src/util.h | 2 - src/virterror.c | 3 + 8 files changed, 769 insertions(+), 2 deletions(-)
diff --git a/include/libvirt/libvirt.h b/include/libvirt/libvirt.h index f2e695a..886c400 100644 --- a/include/libvirt/libvirt.h +++ b/include/libvirt/libvirt.h @@ -433,6 +433,24 @@ extern virConnectAuthPtr virConnectAuthPtrDefault;
#define VIR_UUID_STRING_BUFLEN (36+1)
+/** + * VIR_MAC_BUFLEN: + * + * This macro provides the length of the buffer required + * for an interface MAC address + */ + +#define VIR_MAC_BUFLEN (6)
We might need to make this a little longer to be safe to cope with devices that a non-Ethernet based. eg wmaster0 and tun0 (Vpn) have hardware addresses that are 16 bytes long [snip] The rest of this plumbing all looks fine to me - its pretty standard stuff and all just derives from the public API defintions. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|