Re: [virttools-planet PATCH 2/4] Introduce use of GitLab CI for publishing to GitLab Pages
On Tue, 2020-03-31 at 11:08 +0100, Daniel P. Berrangé wrote:
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
new file mode 100644
index 0000000..cfc6bf6
--- /dev/null
+++ b/.gitlab-ci.yml
@@ -0,0 +1,14 @@
+
+image: centos:7
CentOS 7, ewww.
+pages:
+ stage: build
+ cache:
+ paths:
+ - cache/
+ key: "$CI_JOB_NAME"
+ script:
+ - python2 planet.py virt-tools/config.ini
Python 2, EWWWWW!
IIUC Planet itself is abandonware now, and has been for a fairly long
time. Can we investigate an alternative?
+++ b/README.md
@@ -34,14 +33,11 @@ Please send a patch email to `libvir-list(a)redhat.com`:
How to run the site
-------------------
-The site is setup to run under OpenShift
+The site is intended to be published with GitLab Pages
Missing period here.
+++ b/virt-tools/basic/index.html.tmpl
@@ -23,7 +23,7 @@
<TMPL_LOOP Channels>
<li><a href="<TMPL_VAR link ESCAPE="HTML">"
title="<TMPL_VAR title ESCAPE="HTML">"><TMPL_VAR
name></a> <a href="<TMPL_VAR url
ESCAPE="HTML">">(feed)</a></li>
</TMPL_LOOP>
- <li><a
href="https://libvirt.org/git/?p=virttools-planet.git;a=blob;f=READM...
your blog!</a></li>
+ <li><a
href="https://gitlab.com/libvirt/virttools-planet/-/blob/master/READ...
your blog!</a></li>
I think we can just point people to the repository.
@@ -73,9 +73,8 @@
<div id="planetfooter">
<a href="http://www.planetplanet.org/">Powered by
Planet!</a><br>
<em>Last updated: <TMPL_VAR date></em>
- <a href="https://www.openshift.com/" title="Powered by OpenShift
Online"><br>
- <img alt="Powered by OpenShift Online"
src="https://www.openshift.com/images/logos/powered_by_openshift_rev...
- </a>
+ &emdash;
+ <a
href="https://gitlab.com/libvirt/virttools-planet/-/blob/master/virt...
title="Edit this page">Edit this page</a>
This seems unnecessary. If anything, we might consider replacing the
original OpenShift Online "powered by" with GitLab Pages.
If you add the missing period and leave out the "edit this page"
link,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization
![src="https://www.openshift.com/images/logos/powered_by_openshift_rev...](http://src="https://www.openshift.com/images/logos/powered_by_openshift_reverse.png%22%3E){kind=link}