On 10/09/2013 07:46 AM, Daniel P. Berrange wrote:
Consistent output, as long as we accept exactly one of the two names on input, seems reasonable to me. Then again, if we released documentation of one particular spelling, it's better to preserve that spelling for back-compat, even if inconsistent. As we didn't document ANY name (whether 'unit' or 'units'), I'd much rather output a consistent name.
The current libvirt releases print 'units' and the libvirt-glib and libvirt-sandbox libraries are parsing 'units', so renaming it to 'unit' will break that.
So back-compat IS a concern, and we MUST output 'units'. So much for consistency, but back-compat wins every time. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org