On 08/29/2014 06:17 AM, Christophe Fergeau wrote:
Hey,
On Fri, Aug 29, 2014 at 11:08:53AM +0200, Martin Kletzander wrote:
Although my git was a bit confused by the diff included in the commit message. I'd suggest just saying that most of the commit is a whitespace change; people can see that using '-w' themselves. That toggle should even work with format-patch, but I'm not sure that applies cleanly all the time.
Ah I did not know git format-patch has such as switch. This produces a readable patch, but it's indeed not possible to apply it cleanly. I could have sent the readable version in reply to the full version though.
I've removed the diff from the commit log, but on second thought I forgot to remove one 'always true' test so I'll send a v2.
Sometimes, when a patch is that invasive, I'll do it in two parts - the change with wrong indentation, followed by another patch that is indentation-only. Much easier to review. Also, are you using the patience algorithm with git? (git config diff.algorithm patience) It makes indentation patches easier to review, by not trying to interleave lone } and blank lines that correspond to different code from pre- and post-patch. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org