Re: [libvirt] [PATCH] kvm: maxVCPU runtime detection
Guido Günther wrote:
Guido Günther wrote:
> Hi,
> On Fri, Aug 22, 2008 at 02:27:58PM +0100, Daniel P. Berrange wrote:
>> On Fri, Aug 22, 2008 at 03:16:42PM +0200, Guido G?nther wrote:
>>> Hi,
>>> with recent linux kernels we can detect the maximum number of virtual
>>> cpus at runtime via an ioctl. Possible patch attached. It does this on
>>> every call to qemudGetMaxVCPUs. Would you prefer something that does
>>> this only once in qemudStartup()?
Any comments on this one? Or is this too obviously broken?
-- Guido
I'm not too savvy on the header stuff but it looks
good to me.
FYI, I'm about to post a patch that builds on this
to offer max vcpu checking based on the kvm version
which is parsed from the help message. Should also
help providing useful values for older kernels and
kvm versions.
Thanks,
Cole