Re: [libvirt] [PATCH] build: force correct gcc syntax for attribute_nonnull

On 02/18/2013 01:47 PM, Laine Stump wrote:

On 02/18/2013 03:42 PM, Eric Blake wrote:

...

Gcc lets you do:

int ATTRIBUTE_NONNULL(1) foo(void *param); int foo(void *param) ATTRIBUTE_NONNULL(1); int ATTRIBUTE_NONNULL(1) foo(void *param) { ... }

but chokes on:

int foo(void *param) ATTRIBUTE_NONNULL(1) { ... }

...

* src/internal.h (ATTRIBUTE_NONNULL): Expand to empty attribute, rather than nothing, when on gcc.

ACK.

Thanks; pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org