Re: [libvirt PATCH 21/25] vircgroup: drop @create from virCgroupNewDomainPartition
On 11/3/20 7:41 AM, Pavel Hrdina wrote:
All callers pass true.
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/util/vircgroup.c | 5 +----
src/util/vircgrouppriv.h | 1 -
tests/vircgrouptest.c | 4 ++--
3 files changed, 3 insertions(+), 7 deletions(-)
[...]
diff --git a/src/util/vircgrouppriv.h b/src/util/vircgrouppriv.h
index 7248bc1d35..77e01519b0 100644
--- a/src/util/vircgrouppriv.h
+++ b/src/util/vircgrouppriv.h
@@ -123,7 +123,6 @@ int virCgroupNewPartition(const char *path,
int virCgroupNewDomainPartition(virCgroupPtr partition,
const char *driver,
const char *name,
- bool create,
virCgroupPtr *group)
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(5);
^^ FYI:
This breaks the Coverity build - need to use ATTRIBUTE_NONNULL(4)
John
[...]