On 07/23/2014 12:13 AM, Martin Kletzander wrote:
On Fri, Jul 18, 2014 at 03:23:51PM -0600, Eric Blake wrote:
Commit 5028160 accidentally weakened the strtol prohibitions to skip ALL files under src/util instead of the former situation of just protecting util/virsexpr.c; even though NONE of the files in that directory need any protection.
Shorten some long lines while at it.
* cfg.mk (exclude_file_name_regexp--sc_prohibit_strtol): No need to exclude all of util. (exclude_file_name_regexp--sc_prohibit_sprintf): Reduce long line. (exclude_file_name_regexp--sc_prohibit_raw_allocation): Likewise.
+ ^(docs/hacking\.html\.in|.*stp|.pl)$$
This fails for me even though the regexp makes sense. Either (a) adding an asterisk before 'pl' (the same way as for '.*stp') or (b) encapsulating the caret in the parentheses should work, probably one of those you meant to do.
Oops, serves me right for testing one version, then tweaking, then posting, without retesting.
ACK with that changed,
Fixed and pushed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org