Re: [libvirt] [PATCH 20/53] vircgroup: register cgroup v2 backend
On 10/02/2018 10:44 AM, Pavel Hrdina wrote:
All mandatory callbacks are implemented for cgroup v2 backend so we
can register it now.
Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
---
src/util/vircgroupbackend.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/util/vircgroupbackend.c b/src/util/vircgroupbackend.c
index 79fe6cb73d..7ee39ac8ca 100644
--- a/src/util/vircgroupbackend.c
+++ b/src/util/vircgroupbackend.c
@@ -52,6 +52,7 @@ virCgroupBackendRegister(virCgroupBackendPtr backend)
static void
virCgroupBackendOnceInit(void)
{
+ virCgroupV2Register();
virCgroupV1Register();
}
Well, the callbacks are implemented, but that's about it. No API that
involves reading/setting a value from CGroup will work at this point, oui?
For instance:
virsh blkiotune fedora
error: Operation not supported: operation 'getBlkioWeight' not supported
ACK if you move this to be the very last patch (or somewhere before the
tests - I haven't gotten that far yet, so I don't know how tests are
implemented, whether they need the v2 backend to be registered or not).
Michal