Re: [libvirt] [PATCHv2] esx: Support folders in the path of vpx:// connection URIs

On 11/01/2011 10:21 AM, Matthias Bolte wrote: > > Allow the datacenter and compute resource parts of the path > to be prefixed with folders. Therefore, the way the path is > parsed has changed. Before, it was split in 2 or 3 items and > the items' meanings were determined by their positions. Now > the path can have 2 or more items and the the vCenter server > is asked whether a folder, datacenter of compute resource > with the specified name exists at the current hierarchy level. > > Before the datacenter and compute resource lookup automatically > traversed folders during lookup. This is logic got removed > and folders have to be specified explicitly. > > The proper datacenter path including folders is now used when > accessing a datastore over HTTPS. This makes virsh dumpxml > and define work for datacenters in folders. > > https://bugzilla.redhat.com/show_bug.cgi?id=732676 Looks reasonable and passed a compile test for me.  I'm not set up to test it very well, but it looked like you properly handled errors without leaks, and that it adds more flexibility into the parsing while still supporting older styles, so I don't think it will cause regressions. ACK.