Re: [libvirt] [PATCH v2 13/29] conf: Merge virDomainStorageSourceFormat into virDomainDiskSourceFormat

On 3/22/19 1:00 PM, Peter Krempa wrote: > There was only one caller, remove the unnecessary wrapper. > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > --- > src/conf/domain_conf.c | 60 ++++++++++++++++-------------------------- > 1 file changed, 23 insertions(+), 37 deletions(-) Alas, my backup code wants to be a second caller. https://www.redhat.com/archives/libvir-list/2019-March/msg00393.html virDomainStorageSourceFormat was a nice independent function that did not care what element it was being formatted to; virDomainDiskSourceFormat always formats into <disk ....>. But backup wants to format into <target> (push mode) or <scratch> (pull mode). So I'll be including a revert of this patch in my next round of incremental backup patches.