On Fri, Jun 30, 2017 at 01:08:22PM -0400, John Ferlan wrote:
On 06/30/2017 08:06 AM, Erik Skultety wrote:
On Sat, Jun 03, 2017 at 09:11:58AM -0400, John Ferlan wrote:
Create local @obj and @def for the API's rather than referencing the devs->objs[i][->def->]. It'll make future patches easier to read.
^^^^^^^^^ [1]
Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/conf/virnodedeviceobj.c | 60 ++++++++++++++++++++++++++++----------------- 1 file changed, 37 insertions(+), 23 deletions(-)
diff --git a/src/conf/virnodedeviceobj.c b/src/conf/virnodedeviceobj.c index fab1cfd..a9187be 100644 --- a/src/conf/virnodedeviceobj.c +++ b/src/conf/virnodedeviceobj.c @@ -172,12 +172,16 @@ virNodeDeviceObjListFindBySysfsPath(virNodeDeviceObjListPtr devs, size_t i;
for (i = 0; i < devs->count; i++) { - virNodeDeviceObjLock(devs->objs[i]); - if ((devs->objs[i]->def->sysfs_path != NULL) && - (STREQ(devs->objs[i]->def->sysfs_path, sysfs_path))) { - return devs->objs[i]; + virNodeDeviceObjPtr obj = devs->objs[i]; + virNodeDeviceDefPtr def;
Although with good intension, I think having virNodeDeviceObjPtr obj = foo only will make all the difference, thus dereferencing @def is IMHO not that much more beneficial.
[1] I'm trying to avoid syntax such as:
devs->objs[i]->def->sysfs_path
or
objs->def->sysfs_path
If some day ->def is "owned-by" some vir*Object, then -> def would need to be fetched, e.g. def = virObject*GetDef(obj), so this just makes that future easier.
Yeah, I'm realizing it was a pointless suggestion, strange I didn't even think about that when I was looking at 10/12, you can disregard my previous comment then...^good point btw. ACK as is. Erik