On Mon, Aug 04, 2008 at 10:34:31AM +0100, Daniel P. Berrange wrote:
On Sun, Aug 03, 2008 at 01:41:28AM +0200, Guido G?nther wrote:
Hi, attached is a second version. Changes are:
* s/bus/subsystem/ * support hexadecimal and decimal attributes * introduce device and source elements.
I decided to not drop vendor and product id into their own elements since the structure would then become very nested for no good reason.
The reason is that I want it to match the host device enumeration XML format. This will be using explicit <product> and <vendor> tags, with an 'id' attribute, because there will be text content in the body giving the human readable name. Ahh...o.k.
Some examples:
<hostdev mode="subsys" type='usb'> <source> <device vendor="0x0204" product="0x6025"/>
So this needs to be changed to
<vendor id="0x0204"/> <product id="0x6025"/>
Sure.
Ok, that's not critical, but the other things we need before we can commit this are
- Code to format XML for output, so that the devices are included when dumping the XML description of a guest. - Update to the RNG schema in docs/libvirt.rng - Example XML data files in tests/qemuxml2argvdata/, along with the corresponding CLI args for QEMU. THis is then hooked into the qemuxml2argvtest.c and qemuxml2xmltest.c files Sure. I delayed those since they'd have to be adjusted when the XML changes, I'll add them now and do the other minor touchups you suggested...might be a couple of days though. -- Guido