On Wed, Mar 23, 2011 at 10:38:25AM -0600, Eric Blake wrote:
* libvirt.spec.in (Requires): Reorganize requirements a bit; no functional change. ---
v3: new patch, to cleanly separate Requires: from BuildRequires:.
Should I also do a patch to sort requirements, to make it easier to know where to insert new requirements (in sorted order)?
libvirt.spec.in | 18 +++++++++++++----- 1 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 4a62c80..4f1bdc8 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -225,7 +225,9 @@ Group: Development/Libraries Source: http://libvirt.org/sources/libvirt-%{version}.tar.gz BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root URL: http://libvirt.org/ -BuildRequires: python-devel + +# All runtime requirements for the libvirt package (runtime requrements +# for subpackages are listed later in those subpackages)
# The client side, i.e. shared libs and virsh are in a subpackage Requires: %{name}-client = %{version}-%{release} @@ -259,10 +261,6 @@ Requires: PolicyKit >= 0.6 %endif %endif %if %{with_storage_fs} -# For mount/umount in FS driver -BuildRequires: util-linux -# For showmount in FS driver (netfs discovery) -BuildRequires: nfs-utils Requires: nfs-utils # For glusterfs %if 0%{?fedora} >= 11 @@ -303,6 +301,10 @@ Requires: device-mapper %if %{with_cgconfig} Requires: libcgroup %endif + +# All build-time requirements +BuildRequires: python-devel + %if %{with_xen} BuildRequires: xen-devel %endif @@ -414,6 +416,12 @@ BuildRequires: audit-libs-devel BuildRequires: systemtap-sdt-devel %endif
+%if %{with_storage_fs} +# For mount/umount in FS driver +BuildRequires: util-linux +# For showmount in FS driver (netfs discovery) +BuildRequires: nfs-utils +%endif
# Fedora build root suckage BuildRequires: gawk
ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|