Re: [libvirt] [PATCH V2 2/5] implement remote protocol for domainSendSysrq

On 12/12/14 12:49, John Ferlan wrote: > > > On 12/12/2014 04:04 AM, Chunyan Liu wrote: >> Signed-off-by: Chunyan Liu <cyliu(a)suse.com&gt; >> --- >> src/remote/remote_driver.c | 2 +- >> src/remote/remote_protocol.x | 13 ++++++++++++- >> 2 files changed, 13 insertions(+), 2 deletions(-) >> >> struct remote_domain_send_process_signal_args { >> remote_nonnull_domain dom; >> hyper pid_value; >> @@ -5550,5 +5555,11 @@ enum remote_procedure { >> * @generate: none >> * @acl: domain:fs_freeze >> */ >> - REMOTE_PROC_DOMAIN_GET_FSINFO = 349 >> + REMOTE_PROC_DOMAIN_GET_FSINFO = 349, >> + >> + /** >> + * @generate: both >> + * @acl: domain:send_input >> + */ > > Just send_input? The result of the send is essentially 'init_control' > right? Like a shutdown. Perhaps even like destroy (eg, 'stop'). Or > 'shutdown'... I'm not sure of all the options here, but this seems much > more invasive than just sending input because the result of the sent key > is a bit more "final". Since you are able to do the same thing with the virDomainSendKey API which has the same ACL class: virsh send-key dom KEY_LEFTALT KEY_SYSRQ KEY_O I don't think it should require any other permission since it's just a keystroke basically.