Re: [libvirt PATCH v2 2/2] Corrected names in comments
On 6/14/23 07:21, K Shiva wrote:
Signed-off-by: K Shiva <shiva_kr(a)riseup.net>
---
This patch applies to:
https://listman.redhat.com/archives/libvir-list/2023-June/240299.html
src/conf/virnetworkobj.c | 8 ++++----
src/libvirt-network.c | 10 +++++-----
2 files changed, 9 insertions(+), 9 deletions(-)
If you notice any problem with your earlier patch, it's common practice
to send the next version fully (i.e. no diffs to your patches) and
ideally reply to the previous version stating what's wrong and that
you've sent next version. For instance:
A reply to the original patch (say v2):
Oh, this leaks memory in case when user passes flags X and Y. Fixed
version can be found here:
https://listman.redhat.com/archives/libvir-list/.....
And in the v3 place a note:
${commitMessage}
Signed-off-by: John Doe <jdoe(a)example.com>
---
v3 of:
${linkToV2}
diff to v2:
- Fixed a memleak when X and Y are passed
${diffStatHere}
You found the right place - it's exactly where you put your comment.
Michal